8000 [CEP 25] Versioning of Existing conda Standards by beckermr · Pull Request #119 · conda/ceps · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[CEP 25] Versioning of Existing conda Standards #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 25 commits into from
May 7, 2025
Merged

Conversation

beckermr
Copy link
Contributor
@beckermr beckermr commented Mar 14, 2025

Checklist for submitter

  • I am submitting a new CEP: Versioning of Existing conda Standards.
    • I am using the CEP template by creating a copy cep-0000.md named cep-XXXX.md in the root level.
  • I am submitting modifications to CEP XX.
  • Something else: (add your description here).

Checklist for CEP approvals

  • The vote period has ended and the vote has passed the necessary quorum and approval thresholds.
  • A new CEP number has been minted. Usually, this is ${greatest-number-in-main} + 1.
  • The cep-XXXX.md file has been renamed accordingly.
  • The # CEP XXXX - header has been edited accordingly.
  • The CEP status in the table has been changed to approved.
  • The last modification date in the table has been updated accordingly.
  • The pre-commit checks are passing.

8000
@beckermr
Copy link
Contributor Author

pre-commit.ci autofix

@beckermr beckermr marked this pull request as ready for review March 14, 2025 21:08
@beckermr
Copy link
Contributor Author

@conda/steering-council comments welcome!

@jaimergp
Copy link
Contributor

From #81 (comment):

Also please call the existing format v0.

My understanding from meta.yaml vs recipe.yaml was that v0's were not standardized ever. That's why I am/was using v1 for environment.yml in #81.

Happy to change that assumption though. I'll drop some comments here for clarity.

@jaimergp
Copy link
Contributor

Also, conda-lock is already using v1 vs v2: https://github.com/conda/conda-lock/tree/main/conda_lock/lockfile.

@jaimergp
Copy link
Contributor

And same with repodata.json, never standardized but the current code in conda distinguishes between versions 1 and 2: https://github.com/conda/conda/blob/9eb05d85702aa78fd3793b840d79a910764544f1/conda/core/subdir_data.py#L264

This language is supported by CEP 15 too.

@jaimergp
Copy link
Contributor

Aaand more examples in this search. paths.json versions are 1-indexed, and so are content-trust signatures.

I think we are going to have trouble accepting such a long list of exceptions for this CEP.

My current opinion is that meta.yaml is v0 because it was never and will never be standardized properly given the complexity of the schema, Jinja and selector features. But in all other cases so far, the opportunity for v1 versioning via a proper standardization process is feasible.

@beckermr
Copy link
Contributor Author

Oh no :/

@beckermr beckermr marked this pull request as draft March 18, 2025 11:44
@beckermr
Copy link
Contributor Author

OK @jaimergp. I reversed the logic of the CEP and went with existing things as v1 with an exclusion for recipe formats.

< 8000 div id="commits-pushed-a28403b" data-view-component="true" class="TimelineItem pb-1">
beckermr and others added 3 commits March 20, 2025 12:31
Co-authored-by: jaimergp <jaimergp@users.noreply.github.com>
Co-authored-by: jaimergp <jaimergp@users.noreply.github.com>
@jaimergp
Copy link
Contributor

pre-commit.ci autofix

@beckermr
Copy link
Contributor Author

pre-commit.ci autofix

@beckermr beckermr marked this pull request as ready for review March 31, 2025 11:03
@beckermr
Copy link
Contributor Author

@conda/steering-council I plan to put this CEP up for a vote in ~2.5 weeks. Please send any comments, suggestions, etc. before then!

@jaimergp
Copy link
Contributor
jaimergp commented Apr 22, 2025

Hello @conda/steering-council. Requesting a vote for this CEP.

This vote falls under the "Enhancement Proposal Approval" policy of the conda governance policy,
please vote and/or comment on this proposal at your earliest convenience.

It needs 60% of the Steering Council to vote yes to pass.

To vote, please use the following form to vote. If you have questions concerning the proposal, you may also leave a comment or code review.

This vote will end on 2025-05-06, End of Day, Anywhere on Earth (AoE).

@xhochy (Uwe Korn)

  • yes
  • no
  • abstain

@CJ-Wright (Christopher J. 'CJ' Wright)

  • yes
  • no
  • abstain

@mariusvniekerk (Marius van Niekerk)

  • yes
  • no
  • abstain

@chenghlee (Cheng H. Lee)

  • yes
  • no
  • abstain

@ocefpaf (Filipe Fernandes)

  • yes
  • no
  • abstain

@marcelotrevisani (Marcelo Duarte Trevisani)

  • yes
  • no
  • abstain

@msarahan (Michael Sarahan)

  • yes
  • no
  • abstain

@mbargull (Marcel Bargull)

  • yes
  • no
  • abstain

@jakirkham (John Kirkham)

  • yes
  • no
  • abstain

@jezdez (Jannis Leidel)

  • yes
  • no
  • abstain

@wolfv (Wolf Vollprecht)

  • yes
  • no
  • abstain

@jaimergp (Jaime Rodríguez-Guerra)

  • yes
  • no
  • abstain

@baszalmstra (Bas Zalmstra)

  • yes
  • no
  • abstain

@beckermr (Matthew R. Becker)

  • yes
  • no
  • abstain

@Hind-M (Hind Montassif)

  • yes
  • no
  • abstain

@trallard (Tania Allard)

  • yes
  • no
  • abstain

@jaimergp
Copy link
Contributor

@CJ-Wright, @mariusvniekerk, @chenghlee, @ocefpaf, @marcelotrevisani, @msarahan, @mbargull, @jakirkham, @wolfv: your mid-period reminder to vote, thanks!

@jaimergp
Copy link
Contributor
jaimergp commented May 7, 2025

The vote is closed, and we have the following result:

  • Total possible voters: 16.
  • Valid votes: 12 / 16 = 75%.

Yes votes (12 / 100%):

  1. @xhochy
  2. @chenghlee
  3. @ocefpaf
  4. @marcelotrevisani
  5. @mbargull
  6. @jezdez
  7. @wolfv
  8. @jaimergp
  9. @baszalmstra
  10. @beckermr
  11. @Hind-M
  12. @trallard

No votes (0 / 0.00%).

Abstain votes (0 / 0.00%).

Not voted (4):

  1. @CJ-Wright
  2. @mariusvniekerk
  3. @msarahan
  4. @jakirkham

Invalid votes (0).

12/16 votes = 75% meets the minimum quorum.
12/12 YES votes meets the approval threshold (60%).

As per the governance, the @conda/steering-council has approved this CEP.

@jaimergp jaimergp changed the title [CEP XXXX] Versioning of Existing conda Standards [CEP 25] Versioning of Existing conda Standards May 7, 2025
@jaimergp jaimergp merged commit eafac23 into main May 7, 2025
1 check passed
@jaimergp jaimergp deleted the beckermr-patch-3 branch May 7, 2025 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0