8000 Clarify that Python is not by default included by hugobuddel · Pull Request #10089 · conda/conda · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Clarify that Python is not by default included #10089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 27, 2020
Merged

Conversation

hugobuddel
Copy link
Contributor

The documentation made it appear as if there will always be a version of Python included in the environment.
This might have been the case in the past; currently it is possible to create an environment without Python at al.
See #9982

The documentation made it appear as if there will always be a version of Python included in the environment.
This might have been the case in the past; currently it is possible to create an environment without Python at al.
See conda#9982
@hugobuddel hugobuddel requested a review from a team as a code owner July 21, 2020 12:56
@cla-bot
Copy link
cla-bot bot commented Jul 21, 2020

We require contributors to sign our Contributor License Agreement, and we don't have one on file for @hugobuddel. In order for us to review and merge your code, please e-sign the PDF at https://conda.io/en/latest/contributing.html#conda-contributor-license-agreement. We then need to manually verify your signature. We will ping the bot to refresh the PR status when we have confirmed your signature.

@hugobuddel
Copy link
Contributor Author

We require contributors to sign our Contributor License Agreement, and we don't have one on file for @hugobuddel. In order for us to review and merge your code, please e-sign the PDF at https://conda.io/en/latest/contributing.html#conda-contributor-license-agreement. We then need to manually verify your signature. We will ping the bot to refresh the PR status when we have confirmed your signature.

Signed.

@mcg1969
Copy link
Contributor
mcg1969 commented Jul 21, 2020

@cla-bot check

@cla-bot cla-bot bot added the cla-signed [bot] added once the contributor has signed the CLA label Jul 21, 2020
@cla-bot
Copy link
cla-bot bot commented Jul 21, 2020

The cla-bot has been summoned, and re-checked this pull request!

Copy link
Contributor
@mcg1969 mcg1969 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the comment above! Thanks for this though!

@hugobuddel
Copy link
Contributor Author

See the comment above! Thanks for this though!

After resolving the conversation, I realized it might be convention that only the creator of the thread should mark them as resolved. My apologies if that is the case, this is my first conda PR.

I followed your suggestion, so I suppose you're okay with the change though.

@hugobuddel hugobuddel requested a review from mcg1969 July 22, 2020 13:32
Copy link
Contributor
@mcg1969 mcg1969 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No apologies needed! You did fine. Thank you for your contribution.

@mcg1969 mcg1969 merged commit cc21608 into conda:master Jul 27, 2020
@hugobuddel hugobuddel deleted the patch-1 branch July 30, 2020 10:48
@github-actions
Copy link

Hi there, thank you for your contribution to Conda!

This pull request has been automatically locked since it has not had recent activity after it was closed.

Please open a new issue or pull request if needed.

@github-actions github-actions bot added the locked [bot] locked due to inactivity label Aug 20, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed [bot] added once the contributor has signed the CLA locked [bot] locked due to inactivity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0