8000 ignore virtual packages when searching for constrained packages by jjhelmus · Pull Request #10117 · conda/conda · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

ignore virtual packages when searching for constrained packages #10117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 6, 2020
Merged

ignore virtual packages when searching for constrained packages #10117

merged 2 commits into from
Aug 6, 2020

Conversation

jjhelmus
Copy link
Contributor
@jjhelmus jjhelmus commented Jul 29, 2020 •
edited
Loading

Virtual packages cannot be remove if there are conflicts and therefore
should not be included in a list of constrained packages.

fixes #10116

jjhelmus added 2 commits July 29, 2020 11:22
@jjhelmus
test for env with a constrained virtual package
cbf1669 
Add a test for creating an environment given a virtual package (__glibc)
with a version constraint.
@jjhelmus
ignore virtual pkgs when finding constrained pkgs
f423ea9 
Virtual packages cannot be remove if there are conflictss and therefore
should not be included in a list of constrained packages.
@jjhelmus jjhelmus requested a review from a team as a code owner July 29, 2020 16:27
@cla-bot cla-bot bot added the cla-signed [bot] added once the contributor has signed the CLA label Jul 29, 2020
chenghlee
chenghlee approved these changes Jul 29, 2020
View reviewed changes
Copy link
Contributor
@chenghlee chenghlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chenghlee chenghlee changed the base branch from master to 4.8.x August 6, 2020 16:20
@chenghlee chenghlee merged commit 9d29a93 into conda:4.8.x Aug 6, 2020
@chenghlee chenghlee added this to the 4.8.4 milestone Aug 6, 2020
@chenghlee chenghlee mentioned this pull request Aug 8, 2020
Merged
@ericpre ericpre mentioned this pull request Aug 28, 2020
Merged
@github-actions
Copy link

Hi there, thank you for your contribution to Conda!

This pull request has been automatically locked since it has not had recent activity after it was closed.

Please open a new issue or pull request if needed.

@github-actions github-actions bot added the locked [bot] locked due to inactivity label Aug 20, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chenghlee chenghlee chenghlee approved these changes

Assignees
No one assigned
Labels
cla-signed [bot] added once the contributor has signed the CLA locked [bot] locked due to inactivity
Projects
None yet
Milestone
4.8.4
Development

Successfully merging this pull request may close these issues.

conda cannot create an environment with only a constrained virtual package
2 participants
@jjhelmus @chenghlee
0