resolve #7242 configuration load error message #7243
Conversation
conda/common/configuration.py
Outdated
| "" % (mark.line, mark.column)) | ||
| except ReaderError as err: | ||
| raise ConfigurationLoadError(filepath, " reason: invalid yaml at position %s" | ||
| "" % err.position) |
There was a problem hiding this comment.
Granted, line, column and position should always be integers, but in regards to #6759 / https://github.com/conda/conda/blob/4.6.0a2/conda/__init__.py#L48, I'd prefer every CondaError message to be a static string, e.g., either use
class ConfigurationLoadError(ConfigurationError):
def __init__(self, path, message_addition='', **kwargs):
[...]
raise ConfigurationLoadError(filepath,
" reason: invalid yaml at line %(line)s, column %(column)s",
line=mark.line, column=mark.column)
except ReaderError as err:
raise ConfigurationLoadError(filepath, " reason: invalid yaml at position %(position)s",
position=err.position)or
class ConfigurationLoadError(ConfigurationError):
def __init__(self, path, message_addition=''):
message = "Unable to load configuration file.\n path: %(path)s\n%(message_addition)s"
super(ConfigurationLoadError, self).__init__(message, message_addition=message_addition, path=path)|
Hi kalefranz, The issue is exactly what I met. Regards, |
Signed-off-by: Kale Franz <kfranz@continuum.io>
Signed-off-by: Kale Franz <kfranz@continuum.io>
Signed-off-by: Kale Franz <kfranz@continuum.io>
1b1fa61 to
722b425
Compare
Signed-off-by: Kale Franz <kfranz@continuum.io>
|
Hi there, thank you for your contribution to Conda! This pull request has been automatically locked since it has not had recent activity after it was closed. Please open a new issue or pull request if needed. |
resolve #7242