8000 FIx autocompletion in fish by ohadravid · Pull Request #7575 · conda/conda · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

FIx autocompletion in fish #7575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 24, 2018
Merged

FIx autocompletion in fish #7575

merged 1 commit into from
Jul 24, 2018

Conversation

ohadravid
Copy link
Contributor

Fixes #7412.

The original code used find -printf which does not exist on Mac.
Replaced printf (which is is not posix) with basename and xargs to fix autocompletion in fish.

Thanks!

@ohadravid ohadravid requested a review from a team as a code owner July 24, 2018 11:25
@kalefranz kalefranz added this to the 4.6.0 milestone Jul 24, 2018
Copy link
Contributor
@kalefranz kalefranz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kalefranz kalefranz merged commit 794436d into conda:master Jul 24, 2018
@ohadravid ohadravid deleted the bugfix/fish-completion-on-mac branch July 24, 2018 13:33
@RSully
Copy link
RSully commented Jan 15, 2019

Is this only going to be part of 4.6? This is a current bug in 4.5.12

@RSully
Copy link
RSully commented Jan 15, 2019

Ah I see 4.6 is being released soon (today?). Still, this has been a bug for months 😕

rouge8 added a commit to rouge8/vex that referenced this pull request Dec 16, 2020
`find` on macOS/BSD doesn't support `-printf`. See also
conda/conda#7575.
@github-actions
Copy link

Hi there, thank you for your contribution to Conda!

This pull request has been automatically locked since it has not had recent activity after it was closed.

Please open a new issue or pull request if needed.

@github-actions github-actions bot added the locked [bot] locked due to inactivity label Aug 30, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked [bot] locked due to inactivity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fish env autocomplete broken
3 participants
0