10000 Prepend pip commands with activating env by soapy1 · Pull Request #8263 · conda/conda · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Prepend pip commands with activating env #8263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 13, 2019
Merged

Prepend pip commands with activating env #8263

merged 2 commits into from
Feb 13, 2019

Conversation

soapy1
Copy link
Contributor
@soapy1 soapy1 commented Feb 12, 2019

addresses #8187

@soapy1 soapy1 requested a review from a team as a code owner February 12, 2019 20:22
@soapy1 soapy1 force-pushed the pip-subprocess-wrap branch from ac5b060 to 4938904 Compare February 12, 2019 20:27
@msarahan
Copy link
Contributor

Looks good to me. Once the tests are in order, I think this can go in. @jjhelmus please take a look, since you wrote the original functionality here.

@jjhelmus
Copy link
Contributor

cf: #8229

jjhelmus
jjhelmus reviewed Feb 12, 2019
View reviewed changes
jjhelmus
jjhelmus reviewed Feb 12, 2019
View reviewed changes
conda/core/link.py
fh.write("source \"{}\"\n".format(path))
script_caller = fh.name
command_args = [shell_path, "-x", script_caller]
command = ". \"{}\"\n".format(path)
Copy link
Contributor
@jjhelmus jjhelmus Feb 12, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Calling path directly and not souring is correct here. Thanks for correcting this mistake from #8229.

jjhelmus
jjhelmus reviewed Feb 12, 2019
View reviewed changes
conda/utils.py
tmp_prefix = abspath(join(prefix, '.tmp'))
script_caller = None
if on_win:
comspec = environ[str('COMSPEC')]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This environment lookup can fail but perhaps allowing the exception to propagate is the best option he 8000 re.

@soapy1 soapy1 force-pushed the pip-subprocess-wrap branch from f68e6c8 to b330c79 Compare February 12, 2019 21:19
@soapy1
Copy link
Contributor Author
soapy1 commented Feb 13, 2019

Looks like the python 2.7 tests are hitting the 1hr limit on appveyor

@msarahan msarahan merged commit 8afbb29 into conda:master Feb 13, 2019
@soapy1 soapy1 deleted the pip-subprocess-wrap branch February 13, 2019 03:29
@jpgill86 jpgill86 mentioned this pull request Mar 14, 2019
Closed
@github-actions
Copy link

Hi there, thank you for your contribution to Conda!

This pull request has been automatically locked since it has not had recent activity after it was closed.

Please open a new issue or pull request if needed.

@github-actions github-actions bot added the locked [bot] locked due to inactivity label Aug 29, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jjhelmus jjhelmus jjhelmus approved these changes

Assignees
No one assigned
Labels
locked [bot] locked due to inactivity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@soapy1 @msarahan @jjhelmus
0