Post link last #8350
Post link last #8350
Conversation
dd213c9 to
e6ae17e
Compare
conda/core/link.py
Outdated
| @@ -524,14 +524,39 @@ def _verify(cls, prefix_setups, prefix_action_groups): | |||
| return exceptions | |||
|
|
|||
| @classmethod | |||
| def _execute(cls, all_action_groups): | |||
| def _execute(cls, prefix_action_groups): | |||
| groups = list(interleave(itervalues(prefix_action_groups))) | |||
There was a problem hiding this comment.
Can a tuple be used here rather than a list? Perhaps creating a dictionary with action types would be even better so the actions do not need to be referred to by indices below.
conda/core/link.py
Outdated
| @@ -238,7 +238,7 @@ def execute(self): | |||
| assert not context.dry_run | |||
|
|
|||
| try: | |||
| self._execute(self.prefix_action_groups) | |||
| self._execute(tuple(concat(interleave(itervalues(self.prefix_action_groups))))) | |||
There was a problem hiding this comment.
I often find it better for debugging purposes to have data prep steps separate from function calls. I find that it makes tweaking and inspecting what goes into the function easier. This is not blocking this PR - just something to think about.
|
Is this covered by existing tests, or should we add something new? |
|
Looks like there are some tests https://github.com/conda/conda/blob/master/tests/test_create.py#L2050-L2072. I think they cover the basic functionality. Do you think a test is needed to do something like ensure order of actions running? |
|
That could be good for peace of mind. I think you should do something like: package a: depends on b. post-link script depends on the presence of a file created by b (errors if not present) the key being alphabetical order intentionally not working, and things only working if toposort is done correctly. |
a06dbb9 to
380f82e
Compare
|
failure on appveyor is because the test packages are not available for win-32. Could they be noarch? |
|
Updated packages are kicked the win-32 build |
|
Hi there, thank you for your contribution to Conda! This pull request has been automatically locked since it has not had recent activity after it was closed. Please open a new issue or pull request if needed. |
No description provided.