Breadth first search for conflicts #9006
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
76e45a8 to
021a434
Compare
Closed
def59fd to
fedc4b1
Compare
msarahan
reviewed
Jul 31, 2019
| @@ -409,14 +424,33 @@ def build_conflict_map(self, specs, specs_to_add=None, history_specs=None): | |||
| # records_per_name is a completely arbitrary number here. It is meant to gather more | |||
| # than just one record, to explore the space of dependencies a bit. Doing all of them | |||
| # can be an enormous problem, though. This is hopefully a good compromise. | |||
| records_per_name = 7 | |||
There was a problem hiding this comment.
removing this limit may slow things down a lot. Have you done any kind of speed test? Especially with the anaconda metapackage - the more packages involved, the slower this will go.
There was a problem hiding this comment.
Tried this out with anaconda metapackage, yep slows it down a ton!
msarahan
reviewed
Jul 31, 2019
conda/resolve.py
Outdated
|
|
||
| for spec in spec_order: | ||
| allowed_specs = sdeps[spec] | ||
| ga = GeneralGraph([_ for allowed_pkgs in allowed_specs.values() |
There was a problem hiding this comment.
can we use the graph we already have above, but filter it somehow? Creation of the graph is pretty expensive.
added 15 commits
July 31, 2019 10:19
70d6796 to
c070855
Compare
|
Hi there, thank you for your contribution to Conda! This pull request has been automatically locked since it has not had recent activity after it was closed. Please open a new issue or pull request if needed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.