Add support for local version specs in PYPI installed packages. #9025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
386975e to
bc7b4e1
Compare
|
Thanks! The CLA is a manual thing. I confirm that you have signed it. This looks fine to me. Merging. |
|
Hi there, thank you for your contribution to Conda! This pull request has been automatically locked since it has not had recent activity after it was closed. Please open a new issue or pull request if needed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the PYPI version regex matcher in conda does not support local version identifiers as defined here: https://www.python.org/dev/peps/pep-0440/#appendix-b-parsing-version-strings-with-regular-expressions . The local version spec allows you to add something like:
'1.2.1+<githash>'. In some internal environments (such as ours) local versions are occasionally used, and so this breaks our sharing of conda environments usingconda env export.This patch adds '+' to the
PARTIAL_PYPI_SPEC_PATTERNalong with an additional unit test.I just signed the CLA, but I'm not sure how long it take to propagate :).