8000 Fix boto3 initialization race condition by hajapy · Pull Request #9037 · conda/conda · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix boto3 initialization race condition #9037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 2, 2019
Merged

Conversation

hajapy
Copy link
Contributor
@hajapy hajapy commented Aug 2, 2019

Fixes #8993

@hajapy hajapy requested a review from a team as a code owner August 2, 2019 02:41
@msarahan
Copy link
Contributor
msarahan commented Aug 2, 2019

This looks fine to me. I'm calling it a night, but will merge in the morning. I don't see any reason why this would break tests, but good to wait anyway.

The CLA thing is manual. I confirmed that you have signed it, and I'll do the work to get that set up. You can ignore that failing status here.

@msarahan
Copy link
Contributor
msarahan commented Aug 2, 2019

Ah, I forgot: Thanks!

@hajapy
Copy link
Contributor Author
hajapy commented Aug 2, 2019

Not sure I understand the failures here and how they could be related to these changes.

@msarahan
Copy link
Contributor
msarahan commented Aug 2, 2019

all good. Failures are unrelated. Thanks again.

@msarahan msarahan merged commit c150add into conda:master Aug 2, 2019
@hajapy hajapy deleted the patch-1 branch August 3, 2019 12:18
@hokira
Copy link
hokira commented Aug 8, 2019

@msarahan Hi, we're experiencing this issue now and would like to try 4.7.11 to fix this issue. Is there a way to download the latest one? It seems the latest one from the below page still gives 4.7.10, which doesn't include this fix:

https://docs.conda.io/en/latest/miniconda.html

Thanks!

@forrestwaters
Copy link
Contributor

@hokira you can get it from the conda-canary channel for now: https://www.anaconda.com/what-conda-canary/

conda config --add channels conda-canary
conda update conda

@hokira
Copy link
hokira commented Aug 8, 2019

Yes, that worked, thanks! Also it seems the latest download link now points to 4.7.11, I guess you updated it as well, thank you.

@github-actions
Copy link

Hi there, thank you for your contribution to Conda!

This pull request has been automatically locked since it has not had recent activity after it was closed.

Please open a new issue or pull request if needed.

@github-actions github-actions bot added the locked [bot] locked due to inactivity label Aug 24, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked [bot] locked due to inactivity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

S3 channels failing with new multi-threaded package metadata retrieval
4 participants
0