8000 Revert previously merge "init bash completion" PR by tartansandal · Pull Request #9421 · conda/conda · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Revert previously merge "init bash completion" PR #9421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 11, 2019
Merged

Revert previously merge "init bash completion" PR #9421

merged 3 commits into from
Nov 11, 2019

Conversation

tartansandal
Copy link
Contributor

The previously accepted PR, while it working in many cases, depended on the user having the bash-completion library installed on their system. This is very common on most Linux desktop systems, but less so on MacOS.

This feature is now provided by the conda-bash-completion package, which depends on a specially patched bash-completion package.

@tartansandal tartansandal requested a review from a team as a code owner November 8, 2019 23:40
@cla-bot cla-bot bot added the cla-signed [bot] added once the contributor has signed the CLA label Nov 8, 2019
@msarahan
Copy link
Contributor

Thanks @tartansandal !

@msarahan msarahan merged commit d853795 into conda:master Nov 11, 2019
@forrestwaters forrestwaters mentioned this pull request Dec 16, 2019
Closed
@tartansandal
Copy link
Contributor Author

Hi @msarahan. It seems the code that this PR reverts has made its way into the 4.8.0 release 😱

Since this gets loaded early, the new 'packaged' completion code, with all the bugfixes, never gets called. Be good if this PR could integrated soon. I'm already seeing users with the broken code.

@msarahan
Copy link
Contributor

Yep, my bad on not paying attention to that. A lot of code got merged along with this since the 4.8.0 cut. We'll get a release cut today, but it will need to go through some "canary" time.

@tartansandal tartansandal mentioned this pull request Dec 20, 2019
Closed
@tartansandal
Copy link
Contributor Author

Thanks for that mike 😄 Really appreciate all your efforts with rolling out new releases, with so many PRs to evaluate and manage.

@github-actions
Copy link

Hi there, thank you for your contribution to Conda!

This pull request has been automatically locked since it has not had recent activity after it was closed.

Please open a new issue or pull request if needed.

@github-actions github-actions bot added the locked [bot] locked due to inactivity label Aug 22, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
cla-signed [bot] added once the contributor has signed the CLA locked [bot] locked due to inactivity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tartansandal @msarahan
0