8000 fix #9737 --json with inconsistent environment by speleo3 · Pull Request #9738 · conda/conda · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix #9737 --json with inconsistent environment #9738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 24, 2020
Merged

fix #9737 --json with inconsistent environment #9738

merged 1 commit into from
Jul 24, 2020

Conversation

speleo3
Copy link
Contributor
@speleo3 speleo3 commented Mar 6, 2020

Send "inconsistent environment" warning to STDERR instead of STDOUT.

@speleo3 speleo3 requested a review from a team as a code owner March 6, 2020 10:19
@cla-bot cla-bot bot added the cla-signed [bot] added once the contributor has signed the CLA label Mar 6, 2020
angloyna
angloyna previously approved these changes Jul 22, 2020
View reviewed changes
Copy link
Contributor
@angloyna angloyna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need tests rerun, but LGTM

@angloyna angloyna dismissed their stale review July 22, 2020 16:17

my review. tests fail with the intended behavior, need to think on it

@angloyna
Copy link
Contributor

@speleo3 looks like test_conda_recovery_of_pip_inconsistent_env is expecting stderr to be empty. Would you be able to rewrite that test to work for this new behavior?

@speleo3
Copy link
Contributor Author
speleo3 commented Jul 24, 2020

@angloyna test should be fixed now.

@angloyna angloyna merged commit 49783e8 into conda:master Jul 24, 2020
@github-actions
Copy link

Hi there, thank you for your contribution to Conda!

This pull request has been automatically locked since it has not had recent activity after it was closed.

Please open a new issue or pull request if needed.

@github-actions github-actions bot added the locked [bot] locked due to inactivity label Aug 20, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@angloyna angloyna angloyna approved these changes

Assignees
No one assigned
Labels
cla-signed [bot] added once the contributor has signed the CLA locked [bot] locked due to inactivity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@speleo3 @angloyna
0