Sort BaseLockedDependency.dependencies when alpha-sorting a Lockfile #654
Conversation
✅ Deploy Preview for conda-lock ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Thanks! LGTM. I don't see any need for tests here because I don't think we need to guarantee this as an interface contract. Do you know what's leading to the unsorted dependencies? Can you provide a minimal example? In my lockfiles they're sorted. Is it coming from pip dependencies? |
Interesting question, I don't believe it was pip dependencies but will double check my local example where I saw it and post. |
|
Closing and reopening to trigger ci |
Looking at my example (unfortunately I cannot shared due to private repo) it happens for conda packages but only when adding packages to my source Wonder if this is only happening when loading from an existing lock file. Tried looking for something obvious, but nothing stood out. Now ready for review. |
I want to keep the models as simple as possible, and we might as well just alphasort within the preexisting alphasort function.
|
Thanks @peterbygrave! I made a few very minor tweaks and will squash-merge once the tests pass. |
…onda#654) Sort BaseLockedDependency.dependencies when alpha-sorting a Lockfile Co-authored-by: Ben Mares <services-git-throwaway1@tensorial.com>
…onda#654) Sort BaseLockedDependency.dependencies when alpha-sorting a Lockfile Co-authored-by: Ben Mares <services-git-throwaway1@tensorial.com>
Description
When writing a conda-lock.yml file, the
package.dependenciesare not sorted. This can cause more lines to change than strictly needed when e.g. adding a new package that does not alter any existing packages. This help with merge conflicts etc.I was unsure of the ethos around testing in this repo, but very happy to add tests as needed with some guidance 🙂