8000 More refactoring of lookup module by maresb · Pull Request #738 · conda/conda-lock · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

More refactoring of lookup module #738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 28 commits into from
Oct 29, 2024
Merged

More refactoring of lookup module #738

merged 28 commits into from
Oct 29, 2024

Conversation

maresb
Copy link
Contributor
@maresb maresb commented Oct 26, 2024 •
edited
Loading

Description

Further cleanup of the lookup module

A sleep statement was accidentally merged from previous debugging and is removed here.

I added some well-tested caching functionality for the download of the PyPI mapping lookup. (In reality it's not that helpful since the file is only about 1MB and already downloads very quickly. This was a misplaced optimization.)

@maresb maresb requested a review from a team as a code owner October 26, 2024 22:25
@netlify Netlify
Copy link
netlify bot commented Oct 26, 2024 •
edited
Loading

✅ Deploy Preview for conda-lock ready!

Name Link
🔨 Latest commit 5f3c267
🔍 Latest deploy log https://app.netlify.com/sites/conda-lock/deploys/6720a52a215ab4000811aaec
😎 Deploy Preview https://deploy-preview-738--conda-lock.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

maresb added 15 commits October 27, 2024 08:52
@maresb
Compute current time on-demand
06b0364 
This simplifies the variable scope
@maresb
Eliminate cache prefix in favor of subdirectory
3bf44ce
@maresb
Add "cache" to the parent directory of cache directory as safety
f6d6ef8 
This way we can very easily check that the cache is a cache before we start deleting files.
@maresb
Split cache clearing functionality into a separate function
2886a3f
@maresb
Update comments and docstrings
428a097
@maresb
Handle URL file extensions more robustly
e796ff7
@maresb
Verify that age is nonnegative before using cached value
2e4ff24
@maresb
Refactor _download_to_or_read_from_cache
2b97102
@maresb
Add parameters to caching functions
d7b1b16
@maresb
Move caching-related functionality to a separate module
8d30410
@maresb
Fix ignored dont_check_if_newer_than_seconds parameter
e7ad77e
@maresb
Add uncached_download_file
de2d2ff
@maresb
Replace time.time() with datetime.now().timestamp()
1e7e843
@maresb
Add User-Agent header
dd95d1f
@maresb
Parameterize cache root
9998291
@maresb maresb force-pushed the refactor-lookup-again branch 2 times, most recently from 559adf3 to cf3dda7 Compare October 28, 2024 12:13
@maresb maresb marked this pull request as draft October 28, 2024 12:13
@maresb maresb force-pushed the refactor-lookup-again branch from a0f5fe2 to e5c8f36 Compare October 28, 2024 20:53
@maresb maresb marked this pull request as ready for review October 28, 2024 20:56
@maresb maresb force-pushed the refactor-lookup-again branch 2 times, most recently from f04d567 to 68cdf54 Compare October 29, 2024 08:52
@maresb maresb force-pushed the refactor-lookup-again branch from 68cdf54 to 5f3c267 Compare October 29, 2024 09:04
@maresb maresb merged commit 1436bc1 into conda:main Oct 29, 2024
43 checks passed
@maresb maresb deleted the refactor-lookup-again branch October 29, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@maresb
0