Ensure that channel configuration remains identical with --update #817
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for conda-lock ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
c8fd5f2 to
314a70f
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR prevents partial updates when channel configurations change and adds a test to verify the new behavior.
- Add a channel‐change check in
make_lock_filesto raise an error if channels differ on--update - Introduce
test_update_with_changed_channels_raises_errorin the test suite
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| conda_lock/conda_lock.py | Add guard and error message when lockfile channels differ |
| tests/test_conda_lock.py | Add test for update flag raising an error on changed channels |
Comments suppressed due to low confidence (2)
tests/test_conda_lock.py:3497
- The test uses
Channel.from_stringbutChannelis not imported; addChannelto the import list fromconda_lock.lockfile.v1.models.
from conda_lock.lockfile.v1.models import (
tests/test_conda_lock.py:3541
- The test references
DEFAULT_MAPPING_URLbut it is not imported; add an import forDE 8000 FAULT_MAPPING_URL(for example, fromconda_lock.conda_lock).
mapping_url=DEFAULT_MAPPING_URL,
| @@ -385,6 +385,18 @@ def make_lock_files( # noqa: C901 | |||
| if original_lock_content is not None: | |||
| platforms_already_locked = list(original_lock_content.metadata.platforms) | |||
| if update is not None: | |||
| # Check if channels have changed since lockfile was last generated | |||
| if lock_spec.channels != original_lock_content.metadata.channels: | |||
There was a problem hiding this comment.
The error message prints channel URLs but the test asserts channel names ('defaults' and 'conda-forge') should appear; consider including channel names (e.g., c.name or str(c)) in the formatted message.
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If channel order changes, then we need to regenerate the lockfile from scratch (or do something really clever).