This repository was archived by the owner on May 20, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 10
Upgrade to wasmd 0.30.0-rc0 #479
Open
pinosu
wants to merge
10
commits into
main
Choose a base branch
from
upgrade_wasmd_v0.30.0-rc0
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #479 +/- ##
=======================================
Coverage 56.67% 56.67%
=======================================
Files 73 73
Lines 5824 5831 +7
=======================================
+ Hits 3301 3305 +4
- Misses 2200 2203 +3
Partials 323 323
|
alpe
approved these changes
Nov 29, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You did not add the ics29 fee middleware in this upgrade but this is ok for me.
The IBC v4 requires a migration when you skip the v2 release. Please add it to be on the safe side.
8000
app/app.go
@@ -397,7 +397,7 @@ func NewTgradeApp( | |||
// Create static IBC router, add app routes, then set and seal it | |||
ibcRouter := porttypes.NewRouter() | |||
ibcRouter. | |||
AddRoute(wasm.ModuleName, wasm.NewIBCHandler(app.twasmKeeper, app.ibcKeeper.ChannelKeeper)). | |||
AddRoute(wasm.ModuleName, wasm.NewIBCHandler(app.twasmKeeper, app.ibcKeeper.ChannelKeeper, app.ibcKeeper.ChannelKeeper)). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
alpe
reviewed
Nov 29, 2022
@@ -3,10 +3,10 @@ module github.com/confio/tgrade | |||
go 1.18 | |||
|
|||
require ( | |||
github.com/CosmWasm/wasmd v0.29.1 | |||
github.com/CosmWasm/wasmd v0.30.0-rc0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade wasmd to v0.30.0-rc0 and ibc to v4.2.0