gc: fix race and test failures #1650
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows easier debugging of snapshots using labels Signed-off-by: Derek McGowan <derek@mcgstyle.net>
Ensures that all callers and the garbage collector are using the same lock instances to prevent cleanup of objects during creation. Signed-off-by: Derek McGowan <derek@mcgstyle.net>
Codecov Report
@@ Coverage Diff @@
## master #1650 +/- ##
==========================================
+ Coverage 48.67% 48.87% +0.19%
==========================================
Files 27 27
Lines 4074 4080 +6
==========================================
+ Hits 1983 1994 +11
+ Misses 1672 1667 -5
Partials 419 419
Continue to review full report at Codecov.
|
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures that all callers and the garbage collector are using the same lock instances to prevent cleanup of objects during creation.
Locks tend to work better when everything is using the same lock. This was missed during a refactor of the gc code before merge. This should fix the snapshot does not exist test failures.
Also added snapshot label command which I needed to debug.