8000 Add additional container test for missing methods by crosbymichael · Pull Request #1669 · containerd/containerd · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add additional container test for missing methods #1669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 23, 2017
Merged

Add additional container test for missing methods #1669

merged 1 commit into from
Oct 23, 2017

Conversation

crosbymichael
Copy link
Member

Signed-off-by: Michael Crosby crosbymichael@gmail.com

@codecov-io
Copy link
codecov-io commented Oct 20, 2017 •
edited
Loading

Codecov Report

Merging #1669 into master will increase coverage by 0.17%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1669      +/-   ##
==========================================
+ Coverage   48.75%   48.92%   +0.17%     
==========================================
  Files          27       27              
  Lines        4080     4080              
==========================================
+ Hits         1989     1996       +7     
+ Misses       1672     1668       -4     
+ Partials      419      416       -3
Impacted Files Coverage Δ
metadata/db.go 65.5% <0%> (ø) ⬆️
metadata/content.go 31.51% <0%> (+0.47%) ⬆️
metadata/snapshot.go 50.28% <0%> (+0.93%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3679a55...3377121. Read the comment docs.

@crosbymichael
Add additional container test for missing methods
b937d23 
Signed-off-by: Michael Crosby <crosbymichael@gmail.com>
AkihiroSuda
AkihiroSuda approved these changes Oct 22, 2017
View reviewed changes
Copy link
Member
@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

BTW, is there reason not to use testify for integration tests? (not specific to this PR)

@stevvooe
Copy link
Member

LGTM

@AkihiroSuda AkihiroSuda merged commit 230dc74 into containerd:master Oct 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crosbymichael @codecov-io @stevvooe 328F @AkihiroSuda
0