ctr: add commands package with shared utility functions #1679
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jess Valarezo <valarezo.jessica@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #1679 +/- ##
==========================================
- Coverage 48.92% 48.74% -0.18%
==========================================
Files 27 27
Lines 4076 4076
==========================================
- Hits 1994 1987 -7
- Misses 1667 1669 +2
- Partials 415 420 +5
Continue to review full report at Codecov.
|
|
LGTM |
1 similar comment
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the first pass in restructuring
ctr. It moves some shared functions fromctr/utils.gotoctr/commands/commands.go. If this is the direction that we would like to move in I'll continue to move over more shared functions, then start separating out the commands.Background
The end goal is for
ctrto have some support, and for commands to be consistent and scoped.Proposed file structure:
/ctr/commands/for utility functions shared amongst various commandsand a package per command (
ctr snapshot ...ctr images ...``ctr containers...):/ctr/commands/snapshot/ctr/commands/images/ctr/commands/containers/ctr/commands/events/ctr/commands/namespaces/ctr/commands/content/ctr/commands/tasksSigned-off-by: Jess Valarezo valarezo.jessica@gmail.com