[ctr] move version and plugin commands #1683
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Crosby <crosbymichael@gmail.com>
Signed-off-by: Michael Crosby <crosbymichael@gmail.com>
Signed-off-by: Michael Crosby <crosbymichael@gmail.com>
6939edf to
ae995bc
Compare
Codecov Report
@@ Coverage Diff @@
## master #1683 +/- ##
==========================================
+ Coverage 48.72% 48.94% +0.22%
==========================================
Files 27 27
Lines 4076 4076
==========================================
+ Hits 1986 1995 +9
+ Misses 1671 1665 -6
+ Partials 419 416 -3
Continue to review full report at Codecov.
|
| Name: "plugins", | ||
| Usage: "Provides information about containerd plugins", | ||
| Usage: "provides information about containerd plugins", |
There was a problem hiding this comment.
yes! in my PR I will also be normalizing all the help info :)
| Flags: []cli.Flag{ | ||
| cli.BoolFlag{ | ||
| Name: "quiet, q", | ||
| Name: "quiet,q", |
| @@ -64,6 +66,8 @@ containerd CLI | |||
| }, | |||
| } | |||
| app.Commands = append([]cli.Command{ | |||
| plugins.Command, | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jessvalarezo please review and see if this is what you had in mind for the command package.