Add buildmode=pie to makefile #1687
Conversation
1af157c to
f494c61
Compare
|
👍 |
Codecov Report
@@ Coverage Diff @@
## master #1687 +/- ##
==========================================
+ Coverage 48.79% 49.03% +0.23%
==========================================
Files 27 27
Lines 4070 4087 +17
==========================================
+ Hits 1986 2004 +18
+ Misses 1666 1664 -2
- Partials 418 419 +1
Continue to review full report at Codecov.
|
|
I think @justincormack had a use for keeping darwin at least buildable with master? For example, registry interactions could be a reasonable use case on darwin host |
There was a problem hiding this comment.
buildmode LGTM; maybe wait for @justincormack to respond re: darwin
|
I do have a full native Darwin containerd port in a branch which I was
going to merge post 1.0, and I do have use cases for the current partial
port, which can pull.
Buildmode pie for Linux should not affect other architectures...
On 26 Oct 2017 20:00, "Phil Estes" <notifications@github.com> wrote:
*@estesp* approved this pull request.
buildmode LGTM; maybe wait for @justincormack
<https://github.com/justincormack> to respond re: darwin
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1687 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAdcPLk8y8Qpd0wgtMzM__p724kcC4cDks5swNaxgaJpZM4QH8VU>
.
|
Signed-off-by: Michael Crosby <crosbymichael@gmail.com>
|
All the |
|
That would explain the data races. ping @dmcgowan on metadata races -> https://travis-ci.org/containerd/containerd/jobs/293345151#L2398 |
|
I feel like i'm going to have to reinstate the makefile ban. ;) |
Signed-off-by: Michael Crosby <crosbymichael@gmail.com>
|
LGTM |
1 similar comment
|
LGTM |
Signed-off-by: Michael Crosby crosbymichael@gmail.com