ctr: move more commands #1693
ctr: move more commands #1693
Conversation
1b0e51e to
928d177
Compare
Codecov Report
@@ Coverage Diff @@
## master #1693 +/- ##
=======================================
Coverage 49.03% 49.03%
=======================================
Files 27 27
Lines 4087 4087
=======================================
Hits 2004 2004
Misses 1664 1664
Partials 419 419Continue to review full report at Codecov.
|
|
LGTM |
cmd/ctr/commands/images/images.go
Outdated
| listCommand, | ||
| pullCommand, | ||
| pushCommand, | ||
| pushObjectCommand, |
There was a problem hiding this comment.
This should probably go next to fetch-object. The object shouldn't need to be part of an image.
There was a problem hiding this comment.
good catch, i missed that one
928d177 to
c2f75bc
Compare
Signed-off-by: Jess Valarezo <valarezo.jessica@gmail.com>
Signed-off-by: Jess Valarezo <valarezo.jessica@gmail.com>
Signed-off-by: Jess Valarezo <valarezo.jessica@gmail.com>
c2f75bc to
6373272
Compare
|
LGTM |
cmd/ctr/commands/content/content.go
Outdated
| }, | ||
| } | ||
|
|
||
| applyCommand = cli.Command{ |
There was a problem hiding this comment.
@dmcgowan Should we make a subcommand for layer utilities? This is kind of content related, but not directly.
There was a problem hiding this comment.
reading back over what it does, not really content related. We should probably just remove it completely actually, doesn't seem like something we should have in ctr. For ctr we might want a command which could apply a digest, a layer or diff subcommand could hold such utilities. We can merge this move and probably just remove it or change it later.
There was a problem hiding this comment.
My vote is to remove it
There was a problem hiding this comment.
@jessvalarezo perfect, it will not be missed
* in its current state, apply command should not be in ctr Signed-off-by: Jess Valarezo <valarezo.jessica@gmail.com>
6373272 to
7a1d709
Compare
fetch,fetch-object,push-object, tocontentcommandpushandpulltoimagescommandunpacktosnapshotcommandapplycommand