8000 vendor: update ttrpc with latest changes by stevvooe · Pull Request #1831 · containerd/containerd · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

vendor: update ttrpc with latest changes #1831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 30, 2017
Merged

vendor: update ttrpc with latest changes #1831

merged 1 commit into from
Nov 30, 2017

Conversation

stevvooe
Copy link
Member
@stevvooe stevvooe commented Nov 29, 2017 •
edited by crosbymichael
Loading

Fixes #1826

Signed-off-by: Stephen J Day stephen.day@docker.com

@stevvooe stevvooe added this to the 1.0.0 milestone Nov 29, 2017
@estesp
Copy link
Member
estesp commented Nov 29, 2017

Looks like something not exiting or getting hung up in the Travis CI test run. At least it appears to not be making progress.

@crosbymichael
Copy link
Member

Ya, there is something causing containers to run slow with this change.

Did a quick stress test:

before:
create/start/delete 179 containers in 10.171 seconds (17.599 c/sec) or (0.057 sec/c) failures=0

after:
create/start/delete 4 containers in 18.304 seconds (0.219 c/sec) or (4.576 sec/c) failures=0

Its running super slow.

@stevvooe
Copy link
Member Author

@estesp @crosbymichael The status message on TestShimSigkilled is getting lost and causing the test to hang. I'll see what I can do.

@stevvooe
Copy link
Member Author

I think containerd/ttrpc#8 should address the issue.

@stevvooe
Copy link
Member Author

Ok, fixed properly in containerd/ttrpc#8. PTAL and I'll update this with the changes.

@stevvooe
vendor: update ttrpc with latest changes
393cf8e 
Signed-off-by: Stephen J Day <stephen.day@docker.com>
@codecov-io
Copy link
codecov-io commented Nov 30, 2017 •
edited
Loading

Codecov Report

Merging #1831 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1831   +/-   ##
=======================================
  Coverage   49.17%   49.17%           
=======================================
  Files          86       86           
  Lines        8518     8518           
=======================================
  Hits         4189     4189           
  Misses       3659     3659           
  Partials      670      670
Flag Coverage Δ
#linux 49.27% <ø> (ø) ⬆️
#windows 44.25% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96ca973...393cf8e. Read the comment docs.

estesp
estesp approved these changes Nov 30, 2017
View reviewed changes
Copy link
Member
@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crosbymichael
Copy link
Member

LGTM

INFO[1801] create/start/delete 30967 containers in 1800.163 seconds (17.202 c/sec) or (0.058 sec/c) failures=0

@crosbymichael crosbymichael merged commit c4b1114 into containerd:master Nov 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estesp estesp estesp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@stevvooe @estesp @crosbymichael @codecov-io
0