*: image volume feature's follow-up #11605
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unmounting a writable overlayfs can trigger [syncfs][1], causing I/O pressure and impacting running containers. If possible, we should apply volatile option to image volume mount. REF: [1]: containerd#6478 Signed-off-by: Wei Fu <fuweid89@gmail.com>
Signed-off-by: Wei Fu <fuweid89@gmail.com>
Signed-off-by: Wei Fu <fuweid89@gmail.com>
Signed-off-by: Wei Fu <fuweid89@gmail.com>
mikebrow
reviewed
Mar 25, 2025
| @@ -102,7 +102,11 @@ func (c *criService) mutateImageMount( | |||
| target := c.getImageVolumeHostPath(sandboxID, imageID) | |||
|
|
|||
| // Already mounted in another container on the same pod | |||
| if stat, err := os.Stat(target); err == nil && stat.IsDir() { | |||
| mounted, err := ensureImageVolumeMounted(target) | |||
There was a problem hiding this comment.
note to self requires .. "careful" rebase against..: https://github.com/containerd/containerd/pull/11578/files#diff-08bc007bc2a695705409801af29731a387ce26d53e8161dc01e69c7e7e3fa758R107
There was a problem hiding this comment.
I will carefully rebase 😄 since this one is probably merged before mine.
djdongjin
approved these changes
Mar 26, 2025
| @@ -102,7 +102,11 @@ func (c *criService) mutateImageMount( | |||
| target := c.getImageVolumeHostPath(sandboxID, imageID) | |||
|
|
|||
| // Already mounted in another container on the same pod | |||
| if stat, err := os.Stat(target); err == nil && stat.IsDir() { | |||
| mounted, err := ensureImageVolumeMounted(target) | |||
There was a problem hiding this comment.
I will carefully rebase 😄 since this one is probably merged before mine.
djdongjin
reviewed
Mar 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unmounting a writable overlayfs can trigger syncfs - #6478, causing I/O pressure
and impacting running containers. If possible, we should apply volatile
option to image volume mount.
REF: #10579