Remove the support for Schema 1 images #11681
Merged
+56
−885
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Schema 1 (`application/vnd.docker.distribution.manifest.v1+prettyjws`) has been officially deprecated since containerd v1.7 (PR 6884), and disabled since v2.0 (PR 9765). Users who have been seeing warnings like `conversion from schema 1 images is deprecated` now have to rebuild the image with Schema 2 or OCI. Schema 2 was introduced in Docker 1.10 (Feb 2016), so most users should have been already using Schema 2 or OCI. Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
|
https://github.com/containerd/containerd/actions/runs/14392605005/job/40362641392?pr=11681 The CI failure is irrelevant to the changes: |
estesp
approved these changes
Apr 11, 2025
djdongjin
approved these changes
Apr 13, 2025
| @@ -164,7 +163,7 @@ func (c *Client) Pull(ctx context.Context, ref string, opts ...RemoteOpt) (_ Ima | |||
|
|
|||
| if unpacker != nil && ur.Unpacks == 0 { | |||
| // Unpack was tried previously but nothing was unpacked | |||
| // This is at least required for schema 1 image. | |||
| // This was at least required for schema 1 image. | |||
There was a problem hiding this comment.
nit: probably can just remove this line.
There was a problem hiding this comment.
reads fine I think ... history good :)
mikebrow
approved these changes
Apr 16, 2025
The schema 1 images are currently converted to OCI images on pull/import. Those images could be exported/pushed as OCI images. |
dmcgowan
approved these changes
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Schema 1 (
application/vnd.docker.distribution.manifest.v1+prettyjws) has been officially deprecated since containerd v1.7 (PR #6884), and disabled since v2.0 (PR #9765).Users who have been seeing warnings like
conversion from schema 1 images is deprecatednow have to rebuild the image with Schema 2 or OCI.Schema 2 was introduced in Docker 1.10 (Feb 2016), so most users should have been already using Schema 2 or OCI.