Update mount creation to only use btrfs subvolume id #1371
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek McGowan <derek@mcgstyle.net>
Codecov Report
@@ Coverage Diff @@
## master #1371 +/- ##
=========================================
Coverage ? 36.31%
=========================================
Files ? 23
Lines ? 2897
Branches ? 0
=========================================
Hits ? 1052
Misses ? 1608
Partials ? 237
Continue to review full report at Codecov.
|
|
LGTM |
ianlewis
pushed a commit
to ianlewis/containerd
that referenced
this pull request
Dec 8, 2020
…groupns cgroup2: unshare cgroup namespace for containers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is aimed at addressing the flaky btrfs tests. There appears to be a race between creating a subvolume and it showing up in the subvolume map. It is possible this is actually a race between creation and cleanup, but I have not discovered any place where this race occurs. If the flakiness still exists then we can rule out the not found errors. Either way, this change is valid as it avoids unnecessary metadata lookup.