[WIP] attach over ssh #26
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not even close to compiling but this sketches out the structure we'll for providing access to the process io or an allocated TTY. Once this is in place, we can hook it up to an ssh server and profit. Signed-off-by: Stephen J Day <stephen.day@docker.com>
Signed-off-by: Stephen J Day <stephen.day@docker.com>
Signed-off-by: Stephen J Day <stephen.day@docker.com>
e3098d1 to
ebd8a8b
Compare
|
@crosbymichael Are we going in a different direction here? I might actually breakout the ssh server framework into a usable package. Let me know what the plans are for this in containerd. |
|
I like this very much. ssh framework package would be super. |
|
@LK4D4 Here is the single file version: https://gist.github.com/stevvooe/cc8469dd63615e49ae69. I'll probably break that down into a package if we have need of it. |
thaJeztah
added a commit
to thaJeztah/containerd
that referenced
this pull request
Apr 23, 2019
relevant changes: - docker/go-units#19 make 1 second not to be plural seconds - docker/go-units#20 Add `HumanSizeWithPrecision` function - docker/go-units#21 change week display rule - docker/go-units#22 Better human duration precision - docker/go-units#23 Removes spaces before unit - docker/go-units#27 Fix containerd#26 - RAMInBytes Bug - docker/go-units#33 Fix handling of unlimited (-1) ulimit values - docker/go-units#34 Revert 46 minute threshold Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
jepio
pushed a commit
to jepio/containerd
that referenced
this pull request
Dec 3, 2021
Extend README with IgnoreNotExists example
Closed
jseba
pushed a commit
to jseba/containerd
that referenced
this pull request
Aug 25, 2023
refactor rpm build dockerfile for multi stage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sketches out the correct approach to get attach over ssh working. The ssh server portion is fairly complete and tested as part of another project. The PTY handling code and IO creation code and more theoretical.
I have to move on to other work. I am hoping someone can work from this to get attach working with very little effort. It should be a matter of exporting the correct IO representation over the Event bus and then connecting the streams.
Please let me know if you have questions.
cc @crosbymichael