8000 [release/1.0] archive: check whiteout path before removal by dmcgowan · Pull Request #2003 · containerd/containerd · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[release/1.0] archive: check whiteout path before removal #2003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

dmcgowan
Copy link
Member

Cherry pick of #2001

Ensure whiteout is not pointing to the current directory
or parent directory before removing. Protects against invalid
removal of the parent or current directory.

Add whiteout related tar tests using manufactured tar conditions.

Ensure whiteout is not pointing to the current directory
or parent directory before removing. Protects against invalid
removal of the parent or current directory.

Add whiteout related tar tests using manufactured tar conditions.

Signed-off-by: Derek McGowan <derek@mcgstyle.net>
@codecov-io
Copy link

Codecov Report

Merging #2003 into release/1.0 will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release/1.0    #2003      +/-   ##
===============================================
+ Coverage        50.54%   50.57%   +0.02%     
===============================================
  Files               81       81              
  Lines             7136     7140       +4     
===============================================
+ Hits              3607     3611       +4     
  Misses            2838     2838              
  Partials           691      691
Flag Coverage Δ
#linux 50.57% <100%> (+0.02%) ⬆️
Impacted Files Coverage Δ
archive/tar.go 50.76% <100%> (+0.6%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1549dda...ce75ddf. Read the comment docs.

@crosbymichael
Copy link
Member

LGTM

1 similar comment
@stevvooe
Copy link
Member

LGTM

@stevvooe stevvooe merged commit 0a2c2a2 into containerd:release/1.0 Jan 13, 2018
@stevvooe stevvooe added this to the 1.0.1 milestone Jan 13, 2018
@dmcgowan dmcgowan deleted the cherry-pick-fix-whiteout-rootpath-1.0 branch September 10, 2019 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0