content: support manifest labeling on completed content ingests on the client #2117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2117 +/- ##
=======================================
Coverage 45.53% 45.53%
=======================================
Files 80 80
Lines 8726 8726
=======================================
Hits 3973 3973
Misses 4107 4107
Partials 646 646
Continue to review full report at Codecov.
|
stevvooe
reviewed
Feb 9, 2018
| } | ||
|
|
||
| // SetChildrenLabels is a handler wrapper which sets labels for the content on | ||
| // the children returned by the handler and passes through the children. |
There was a problem hiding this comment.
Must follow a handler that returns the children to be labeled.
|
LGTM Nit on the docs. |
Fix issue where manifest content must always be fetched even if it is already fully downloaded or shared locally. Simplify children label setting and platform filtering. Prevent getting a fetcher when content shared locally. Signed-off-by: Derek McGowan <derek@mcgstyle.net>
adc13c7 to
944a9ad
Compare
|
Updated doc, is this ok to cherry-pick to 1.0.x? |
8000
|
LGTM |
|
Waiting until after 1.0.2 to cherry pick |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue where manifest content must always be fetched even if it is already fully downloaded or shared locally. Simplify children label setting and platform filtering. Prevent getting a fetcher when content shared locally.
Note this makes the filtering and labeling more composable, so we could change the behavior more easily (such as if we only wanted to label content which was saved locally, the wrapping order could just be changed).
This is the first PR to support content sharing on the client side. This PR can be backported into 1.0.x to support content sharing in clients based on 1.0.x and containerd 1.1+.