8000 Microoptimize an API use per gopls modernize by mtrmac · Pull Request #2732 · containers/image · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Microoptimize an API use per gopls modernize #2732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 4, 2025
Merged

Microoptimize an API use per gopls modernize #2732

merged 1 commit into from
Mar 4, 2025

Conversation

mtrmac
Copy link
Collaborator
@mtrmac mtrmac commented Feb 24, 2025

No description provided.

Luap99
Luap99 reviewed Feb 28, 2025
View reviewed changes
Copy link
Member
@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

8000

LGTM, interestingly this is the first time I came across Appendf() and searching our sources shows no matches so it seems basically nobody is using it.

@mtrmac
Copy link
Collaborator Author
mtrmac commented Feb 28, 2025

It only exists since Go 1.19. (And, while go run golang.org/x/tools/gopls/internal/analysis/modernize/cmd/modernize@latest -test ./... recommends this change, VS Code does not list it in the “problems” tab.)

@mtrmac
Microoptimize an API use per gopls modernize
08ac56d 
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
@mtrmac mtrmac merged commit c43e62e into containers:main Mar 4, 2025
10 checks passed
@mtrmac mtrmac deleted the cleanups branch March 4, 2025 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Luap99 Luap99 Luap99 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mtrmac @Luap99
0