8000 Improve handling and documentation of various transport reference corner cases by mtrmac · Pull Request #2767 · containers/image · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Improve handling and documentation of various transport reference corner cases #2767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 11, 2025
Merged

Improve handling and documentation of various transport reference corner cases #2767

merged 6 commits into from
Mar 11, 2025

Conversation

mtrmac
Copy link
Collaborator
@mtrmac mtrmac commented Mar 7, 2025

See individual commit messages for details.

(Minimally) fixes #2679 .

Luap99
Luap99 approved these changes Mar 10, 2025
View reviewed changes
Copy link
Member
@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mtrmac added 6 commits March 11, 2025 18:10
@mtrmac
Make a part of TestNewIndexReference table-based
a881850 
Should not change (test) behavior.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
@mtrmac
Explicitly reject daemon.NewReference with no values
19bcd59 
They can't be used anyway (destinations require a reference,
and sources panic), so fail cleanly.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
@mtrmac
Tighten the input validation of NewIndexReference
a0f1cc1 
Reject NewIndexReference with a "missing" index value of -1;
callers can use the other NewReference instead.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
@mtrmac
Document, at least minimally, that image == "" in OCI references is h…
1644809 
…andled specially

Should not change behavior.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
@mtrmac
Beautify doc strings
866803c 
Should not change behavior.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
@mtrmac
Improve transport syntax documentation
67490ae 
The same thing is already said a few lines below.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
@mtrmac mtrmac force-pushed the transport-corner-cases branch from d61dcc0 to 67490ae Compare March 11, 2025 17:12
@mtrmac mtrmac merged commit 6f1abf0 into containers:main Mar 11, 2025
10 checks passed
@mtrmac mtrmac deleted the transport-corner-cases branch March 11, 2025 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Luap99 Luap99 Luap99 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

oci/layout.NewReference (and others?) doesn’t document the image=="" special case
2 participants
@mtrmac @Luap99
0