8000 chore(common/intel_gpus): detect arc a770, a750 by kwaa · Pull Request #1517 · containers/ramalama · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore(common/intel_gpus): detect arc a770, a750 #1517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 13, 2025
Merged

chore(common/intel_gpus): detect arc a770, a750 #1517

merged 1 commit into from
Jun 13, 2025

Conversation

kwaa
Copy link
Contributor
@kwaa kwaa commented Jun 12, 2025 •
edited by sourcery-ai bot
Loading

closed #1515

Summary by Sourcery

Enhancements:

  • Include device IDs 0x56a0 and 0x56a1 to recognize Intel Arc A770 and A750 GPUs in the intel_gpus list

@sourcery-ai Sourcery AI
Copy link
Contributor
sourcery-ai bot commented Jun 12, 2025 •
edited
Loading

Reviewer's Guide

Support for Intel Arc A770 and A750 GPUs was added by including their device IDs in the intel_gpus detection list.

File-Level Changes

Change Details Files
Extend Intel GPU detection list to recognize Arc A770 and A750
  • Add device ID 0x56a0 to intel_gpus tuple
  • Add device ID 0x56a1 to intel_gpus tuple
 ramalama/common.py

Assessment against linked issues

Issue Objective Addressed Explanation
Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

sourcery-ai[bot]
sourcery-ai bot approved these changes Jun 12, 2025
View reviewed changes
Copy link
Contributor
@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @kwaa - I've reviewed your changes and they look great!

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@rhatdan
Copy link
Member
rhatdan commented Jun 13, 2025

@kwaa you have to sign your commits.

git commit -a --amend -s
git push --force

LGTM
Will merge once signed.

@kwaa kwaa force-pushed the chore/intel_gpus branch from 06a140a to 2f81633 Compare June 13, 2025 06:35
@kwaa
Copy link
Contributor Author
kwaa commented Jun 13, 2025

@kwaa you have to sign your commits.

done

@rhatdan
Copy link
Member
rhatdan commented Jun 13, 2025

I don't see the signature?

@kwaa
Copy link
Contributor Author
kwaa commented Jun 13, 2025

I don't see the signature?

image

2f81633

@kwaa
chore(common/intel_gpus): detect arc a770, a750
9172e3f 
Signed-off-by: 藍+85CD <50108258+kwaa@users.noreply.github.com>
@kwaa kwaa force-pushed the chore/intel_gpus branch from 2f81633 to 9172e3f Compare June 13, 2025 07:31
@kwaa
Copy link
Contributor Author
kwaa commented Jun 13, 2025

Well, it looks like it's going to append Signed-off-by to the description.

@taronaeo
Copy link
Collaborator

It appears that DCO is passing. LGTM, merge on green?

@rhatdan rhatdan merged commit 9cc4b7f into containers:main Jun 13, 2025
12 of 16 checks passed
@kwaa kwaa deleted the chore/intel_gpus branch June 13, 2025 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] approved these changes

@rhatdan rhatdan Awaiting requested review from rhatdan rhatdan is a code owner

@ericcurtin ericcurtin Awaiting requested review from ericcurtin ericcurtin is a code owner

@bmahabirbu bmahabirbu Awaiting requested review from bmahabirbu bmahabirbu is a code owner

@maxamillion maxamillion Awaiting requested review from maxamillion maxamillion is a code owner

@swarajpande5 swarajpande5 Awaiting requested review from swarajpande5 swarajpande5 is a code owner

@jhjaggars jhjaggars Awaiting requested review from jhjaggars jhjaggars is a code owner

@cgruver cgruver Awaiting requested review from cgruver cgruver is a code owner

@slp slp Awaiting requested review from slp slp is a code owner

@engelmi engelmi Awaiting requested review from engelmi engelmi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Detects Intel Arc Graphics A770, A750
3 participants
@kwaa @rhatdan @taronaeo
0