Improve how the ide-twig.json file is generated
#8200
Conversation
|
I'm not sure about the implementation, I'm afraid 😞 For example, I don't like that we use a cache warmer to generate the file, but the generated file eventually does not become part of the cache. If the file changes upon rebuilding the cache, it should be stored in
Or, if the file is independent from the Symfony cache, add the |
I think a mandatory cache warmer is probably still the best "injection point": a kernel event listener would run too often (every request, waste of resources) and the There is probably never any difference between prod and dev and the file is not used as a cached resource, so that's why I would not like to have it in |
Btw., it's a mandatory cache warmer, so it won't run at |
|
IMHO we should do it like Symfony and store the file in |
|
The only autogenerated non-cache files of Symfony (I know of) are the |
|
A custom command to generate the file in |
|
As discussed we want to stick with a |
Implements #8051
This PR improves the way the
ide-twig.jsonIDE helper file is generated. Currently we are only creating the file during cache warmup in the dev environment in an optional cache warmer. This is unfortunate because you typically do not explicitly warm the dev cache. We also dumped the file tovar/cachewhich is semantically wrong.Now the file gets dumped to
var/contao-twigin a mandatory cache warmer (still only in dev). In order to 8000 use it you can un-exclude the above directory in your IDE.I also added a new command
contao:dump-twig-ide-filethat dumps the file to a given location in your project dir. This way it will be included by default and can be checked in to version control. In this case, you own the file, so in order to update it, you must manually re-run the command./cc @bytehead