Handle union and intersection types in App services autoloading #8367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Toflar
previously approved these changes
May 23, 2025
leofeyer
reviewed
May 23, 2025
Comment on lines
+290
to
+295
| include_once __DIR__.'/../Fixtures/HttpKernel/AutowireSrc/src/Entity/FooEntity.php'; | ||
| include_once __DIR__.'/../Fixtures/HttpKernel/AutowireSrc/src/EventListener/InvalidListener.php'; | ||
| include_once __DIR__.'/../Fixtures/HttpKernel/AutowireSrc/src/EventListener/ValidListener.php'; | ||
| include_once __DIR__.'/../Fixtures/HttpKernel/AutowireSrc/src/FrontendModule/LegacyModule.php'; | ||
| include_once __DIR__.'/../Fixtures/HttpKernel/AutowireSrc/src/Messenger/UnionTypeMessage.php'; | ||
| include_once __DIR__.'/../Fixtures/HttpKernel/AutowireSrc/src/Model/FooModel.php'; |
There was a problem hiding this comment.
You could omit all this if you used the correct namespaces for these files like we do in the core bundle:
contao/core-bundle/tests/Fixtures/Entity/Author.php
Lines 13 to 21 in 048082b
Then you would not need an ignore-rule for the depcheck, either.
There was a problem hiding this comment.
That won't work, because we only load App services. Same as the test above for the AppBundle.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you currently have a class in your App
/src/folder, which has union or intersection types in the constructor, you get this error:Call to undefined method ReflectionUnionType::isBuiltin() in vendor/contao/manager-bundle/skeleton/config/services.php:93This PR fixes the issue and adds unit tests for the
services.php😎