Use a wrapper for Choices.js #8360
Conversation
|
Didn't we agree on #8351 during the last call? |
There are reportedly some accessibility issues with slim-select. |
You could check out the slim select PR and it does work, however 3 Screenreaders do not read the options at all that were even read by using MooChosen:
Until specific bugs are fixed within SlimSelect, it would be a step backwards and mean that we'd rather solve a Turbo-Issue but exclude blind people completely.. |
|
This solves both (I presume) 🙃 |
|
I think this is the best solution. @m-vo Any objections? |
|
As a bugfix, shouldn't we rebase that onto 5.5 @aschempp ? |
There was a problem hiding this comment.
I did test this PR furiously with navigating back and forth and it works flawlessly better than the current implementation (In that way I am saying that I tested furiously navigating back and forth with debug mode disabled using ⌘ + ← or →😄)
There are some final style changes that need to be addressed but has been tested in filters, types and even with 'multiple' => true.
Shouldn't this however be rebased onto 5.5? (In 5.6 – Should we also rename the controller to something like select-controller and get rid of the contao-component and move the styles into our buildchain?
|
I'm happy to rebase onto 5.5 if we agree and once @zoglo has fixes the styling issues 🙃 |
|
Definitely a bugfix for Contao 5.5 👍 |
960ae9a to
30c3896
Compare
|
Rebase done. @zoglo please add the necessary CSS changes. |
0b4f512 to
30c3896
Compare
These are both good ideas IMHO 👍. Maybe we should only apply the minimal fix as is here and add the improvements upstream, though. |
Instead of reinventing accessibility for another select script or custom shadow dom handling, this simply adds a wrapper DIV to solve the Choices initialization problem. It works 99% out of the box. There might be small CSS issues still in the back end, not sure I catched everything, but they sure are easy to solve.