This repository was archived by the owner on Jun 12, 2024. It is now read-only.
Refactor remove server value from tracing int #8
+87
−68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
444f459 to
4bfd9ac
Compare
**What** - Remove server parameter from the tracing configuration, this value will now be set by Jaeger's own method via the env - Add a new path cleaning method that uses Chi mux route lookup so that we can support name based resolution on its own Signed-off-by: Lucas Roesler <roesler.lucas@gmail.com>
4bfd9ac to
61c4147
Compare
|
Is that test just flaky? I assume you just copied it over right? |
|
The test isn't flaky, it is the github actions environment that is flaky. CircleCI isn't failing, github actions fails everytime. The test also passes locally everytime |
rdner
approved these changes
Aug 15, 2019
Sign up for free
to
6805
subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
will now be set by Jaeger's own method via the env
we can support name based resolution on its own
Based on #7