8000 Check error and use `Ping` in `db.Open` by rdner · Pull Request #37 · contiamo/go-base · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Jun 12, 2024. It is now read-only.

Check error and use Ping in db.Open #37

Merged
merged 1 commit into from
Mar 30, 2020
Merged

Check error and use Ping in db.Open #37

merged 1 commit into from
Mar 30, 2020

Conversation

rdner
Copy link
Contributor
@rdner rdner commented Mar 30, 2020

There was a missing error check and the connection was checked before
breaking out of the backoff loop.

@rdner
Check error and use Ping in db.Open
ccf2409 
There was a missing error check and the connection was checked before
breaking out of the backoff loop.
@rdner rdner added the bug Something isn't working label Mar 30, 2020
@rdner rdner requested review from LucasRoesler and trusch March 30, 2020 13:09
@rdner rdner self-assigned this Mar 30, 2020
@rdner rdner merged commit 8223065 into master Mar 30, 2020
@rdner rdner deleted the fix-db-open branch March 30, 2020 13:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@LucasRoesler LucasRoesler LucasRoesler approved these changes

@trusch trusch trusch approved these changes

Assignees

@rdner rdner

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rdner @LucasRoesler @trusch
0