-
Notifications
You must be signed in to change notification settings - Fork 889
feat: support for npm #410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome! lgtm!
@@ -9,7 +9,7 @@ | |||
<link rel="icon" media="(prefers-color-scheme:dark)" href="/favicon-dark.svg" type="image/svg+xml" /> | |||
<link rel="manifest" href="/manifest.json" /> | |||
<title>GitHub1s</title> | |||
<script>if (window.location.hostname.match(/\.?gitlab1s\.com$/i)) { window.document.title = 'GitLab1s'; } else if (window.location.hostname.match(/\.?bitbucket1s\.org$/i)) { window.document.title = 'Bitbucket1s'; };</script> | |||
<script>if (window.location.hostname.match(/\.?gitlab1s\.com$/i)) { window.document.title = 'GitLab1s'; } else if (window.location.hostname.match(/\.?bitbucket1s\.org$/i)) { window.document.title = 'Bitbucket1s'; } else if (window.location.hostname.match(/\.?npmjs1s\.com$/i)) { window.document.title = 'npm1s'; };</script> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can refactor this to make it reusable in all .html
files without copy paste, I will look into it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes! thank you for your advice, i think we can migrate these to the build scripts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm working on this, will share a PR soon.
We add support for npm in this PR.
For a preview: https://alpha.npmjs1s.com
also add google analytics code here for basic traffic info.