Fix copy extensions #377
Merged
Fix copy extensions #377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 23, 2021 07:04
Previously the script only check if `extensions/emmet/dist/browser` exists, and skip compiling if so. This PR adds an extra `git diff` check, and run compiling if there's any changes in `extensions`.
|
@blindpirate is attempting to deploy a commit to the Github1s Team on Vercel. A member of the Team first needs to authorize it. |
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/vscode-github1s/github1s/BiZdJktfZJ9nv1mVC5xNS6AXr1xn |
|
Great, thank you for catching and fixing this. |
xcv58
approved these changes
Dec 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix in #376 was not complete - because of
set -eincopy-extensions.sh, the script will exit immediately whengit diff --exit-code --name-only extensionsreturns non-zero. Fixed by using||to capture the exit code.Verified locally.