This repository was archived by the owner on Jun 20, 2023. It is now read-only.
Use appScope (14703) #5837
Merged
Use appScope (14703) #5837
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed! |
schauersbergern
approved these changes
Feb 10, 2023
| @@ -89,7 +89,7 @@ class SubmissionSymptomCalendarViewModel @AssistedInject constructor( | |||
| ) | |||
| } | |||
| performSubmission { | |||
| launch { | |||
| appScope.launch { | |||
There was a problem hiding this comment.
Could this also lead to problems elsewhere? vm scope is often used after navigation
There was a problem hiding this comment.
the navigation still performed from vm scope. the issue here is that reporting the flag was also done from vm scope and we navigate immediately which cancels vm scope as we leave the screen and there was no chance to update the flag
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Report flag in appScope , vm scope was cancelled after navigating from screen 🤷♂️
Ticket
https://jira-ibs.wbs.net.sap/browse/EXPOSUREAPP-14703