8000
Allow Android to handle repeated volume button events #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will keep the functionality of not sending repeated "key" events to lua. But allows Android to decrease/increase the volume.
|
It's been a while. Why do you think this should work like that? |
|
Android sends the volume buttons at an interval, currently the implementation blocks the system from handling repeated events by returning true. This change would return false on repeated volume buttons, thus enabling Android to handle them natively. Tested it on Android 8 or 9, not sure which one it was exactly |
ggcrunchy
pushed a commit
to ggcrunchy/corona
that referenced
this pull request
Jul 8, 2021
This will keep the functionality of not sending repeated "key" events to lua. But allows Android to decrease/increase the volume.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will keep the functionality of not sending repeated "key" events to lua. But allows Android to decrease/increase the volume.