8000 Fix for indexed meshes on Android, related to custom vertex formats by ggcrunchy · Pull Request #530 · coronalabs/corona · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix for indexed meshes on Android, related to custom vertex formats #530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 5, 2023
Merged

Fix for indexed meshes on Android, related to custom vertex formats #530

merged 1 commit into from
Mar 5, 2023

Conversation

ggcrunchy
Copy link
Contributor

Custom vertex formats introduced a corner case where these broke due to vertex attributes not being set. This control path wasn't followed if there was a VAO, thus Android being where it was discovered.

The relevant information is now passed along with the binding, and done afterward if a format change isn't also due.

@ggcrunchy
When binding indexed geometry on Android, set up the vertex descripti…
b6156bb 
…on logic in case the format isn't also dirty
@ggcrunchy ggcrunchy requested a review from Shchvova as a code owner March 4, 2023 06:10
@Shchvova Shchvova merged commit 625015e into coronalabs:experimental Mar 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shchvova Shchvova Shchvova approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ggcrunchy @Shchvova
0