Maintenance #812
Maintenance #812
Conversation
| @@ -115,9 +125,11 @@ GLint CalculateOptimalAlignment(U32 width, GLenum format) | |||
| bytesPerPixel = 3; | |||
| break; | |||
|
|
|||
| case GL_RGBA: | |||
| case GL_BGRA_EXT: | |||
There was a problem hiding this comment.
Hi there! I had a quick question about this PR. Was the removal of GL_BGRA_EXT an intentional change? From my understanding, this PR seems to be focused on GL_ABGR_EXT macro definitions, and GL_BGRA_EXT still feels relevant, even if the default outcome is similar.
|
Hey! Thanks for your contributions. I noticed some code-unrelated formatting changes (like indentation/line breaks) in this PR. Since a new version hasn't been released yet, I wonder if we should aim to follow the LLVM "golden rule" of adopting existing styles for uniformity. Just a thought for consistency. Thank you! |
|
@clang-clang-clang I think right now code doesn't have consistent formatting unfortunatelly. I think if your editor applies some formatting that's OK to be honest. Any formatting would be better than whatever we have now. Or does it causes some issues? |
|
There are no issues. |
|
Agree. But also, easily mitigated with |
|
Yep, basically all Git tools have this option. Because I have encountered situations where blank characters affected the operation, I usually perform binary comparison and pay attention to any potential impacts. Especially, Solar2D run and be maintained on multiple platforms, across different programming languages and natural languages, and some resource contents need to be mindful of format changes. Overall, there is no problem. As long as the team can understand each other, everything will be fine. ;D |
|
My mistake I used Xcode to edit your code and which may have messed it up a bit. |
Fixes to pull request "Core: Fixing unpack with alignment"
https://github.com/scottrules44/Solar2D-98/actions/runs/15482662331