-
-
Notifications
You must be signed in to change notification settings - Fork 99
Perf test #232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Perf test #232
Conversation
@MuntasirSZN nice and better to have |
Wait a minute, @avifenesh criterion should not run in ci. |
@MuntasirSZN i dont see where it says no? |
The first line.
|
ahh bummer, i see. ok so its will be just a script |
You can use lai-callgrind... 😀 |
@MuntasirSZN I can but its a little complex to use the results. you probably better run locally before and after and provide the results. |
@MuntasirSZN Sadly removed... |
I like complexity. |
@MuntasirSZN The security need nice amount of fixes for windows so ill break it to two again |
b1534f9
to
b800367
Compare
- Introduced `bench.sh` for local performance benchmarking of RustOwl using Criterion. - Supports saving and loading baselines, regression detection, and custom test packages. - Provides detailed output and HTML report generation. - Added `size-check.sh` for monitoring RustOwl binary sizes. - Implements commands for checking current sizes, creating/updating baselines, and comparing against them. - Warns if binary sizes exceed a specified threshold. Signed-off-by: avifenesh <aviarchi1994@gmail.com>
Bumps [flate2](https://github.com/rust-lang/flate2-rs) from 1.1.1 to 1.1.2. - [Release notes](https://github.com/rust-lang/flate2-rs/releases) - [Commits](rust-lang/flate2-rs@1.1.1...1.1.2) --- updated-dependencies: - dependency-name: flate2 dependency-version: 1.1.2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: avifenesh <aviarchi1994@gmail.com>
…tests Signed-off-by: avifenesh <aviarchi1994@gmail.com>
Co-authored-by: avifenesh <55848801+avifenesh@users.noreply.github.com>
…5f6-a1b2910621de Fix trailing whitespace in benches/rustowl_bench_simple.rs
@MuntasirSZN @cordx56 please review |
This pull request introduces several changes to improve benchmarking, dependency management, and binary size monitoring in the RustOwl project. The most significant updates include adding Criterion-based benchmarks, simplifying dependency versions, replacing the performance testing script with a new binary size monitoring script, and modifying profiles for enhanced security.
Benchmarking and performance improvements:
benches/rustowl_bench_simple.rs
: Added new benchmarks using Criterion for testing RustOwl's performance under different configurations, including default, all targets, all features, and comprehensive analysis.Dependency management:
Cargo.toml
: Simplified dependency versions by removing patch-level specificity, addedcriterion
as a development dependency, and introduced a new[bench]
section for benchmarking.Binary size monitoring:
scripts/size-check.sh
: Introduced a new script for monitoring binary sizes, allowing developers to check, baseline, compare, and clean binary size metrics with configurable thresholds.Profile adjustments:
Cargo.toml
: Changed theinherits
property in the[profile.security]
section fromdev
torelease
to align security settings with optimized builds.Documentation updates:
docs/perf-tests.md
: Removed the outdated performance testing script documentation, as the functionality has been replaced by the new binary size monitoring script.