coreweave · joeyberkovitz · Jun 17, 2025 · Mar 7, 2025 · Apr 11, 2025 · Apr 11, 2025
diff --git a/.github/workflows/check.yml b/.github/workflows/check.yml
@@ -42,6 +42,6 @@ jobs:
         go-version: '1.21'
 
     - name: Run golangci-lint
-      uses: golangci/golangci-lint-action@v6
+      uses: golangci/golangci-lint-action@v8
       with:
-        version: v1.59.1
+        version: v2.1.6
diff --git a/.golangci.yaml b/.golangci.yaml
@@ -1,61 +1,6 @@
-linters-settings:
-  depguard:
-      rules:
-        prevent_unmaintained_packages:
-          list-mode: lax # allow unless explicitly denied
-          files:
-            - $all
-            - "!$test"
-          allow:
-            - $gostd
-          deny:
-            - pkg: io/ioutil
-              desc: "replaced by io and os packages since Go 1.16: https://tip.golang.org/doc/go1.16#ioutil"
-  dupl:
-    threshold: 200
-  funlen:
-    lines: 100
-    statements: 50
-  goheader:
-    values:
-      const:
-        LICENSE: BSD-3-Clause
-    template: |-
-      SPDX-License-Identifier: {{ LICENSE }}
-  goconst:
-    min-len: 2
-    min-occurrences: 5
-  gocritic:
-    enabled-tags:
-      - diagnostic
-      - experimental
-      - opinionated
-      - performance
-      - style
-    disabled-checks:
-      - deprecatedComment
-      - dupImport # https://github.com/go-critic/go-critic/issues/845
-      - ifElseChain
-      - octalLiteral
-      - whyNoLint
-      - wrapperFunc
-  gocyclo:
-    min-complexity: 30
-  goimports:
-    local-prefixes: github.com/stmcginnis
-  govet:
-    enable-all: true
-    disable:
-      - fieldalignment
-  misspell:
-    locale: US
-  nolintlint:
-    allow-unused: false # report any unused nolint directives
-    require-explanation: false # don't require an explanation for nolint directives
-    require-specific: false # don't require nolint directives to be specific about which linter is being skipped
-
+version: "2"
 linters:
-  disable-all: true
+  default: none
   enable:
     - bodyclose
     - depguard
@@ -67,10 +12,8 @@ linters:
     - gocritic
     - gocyclo
     - goheader
-    - goimports
     - goprintffuncname
     - gosec
-    - gosimple
     - govet
     - ineffassign
     - misspell
@@ -80,38 +23,99 @@ linters:
     - revive
     - rowserrcheck
     - staticcheck
-    - stylecheck
-    - typecheck
     - unconvert
     - unparam
     - unused
     - whitespace
-
-  # don't enable:
-  # - asciicheck
-  # - exhaustive
-  # - gochecknoinits
-  # - gochecknoglobals
-  # - gocognit
-  # - godot
-  # - godox
-  # - goerr113
-  # - interfacer
-  # - lll
-  # - nestif
-  # - prealloc
-  # - testpackage
-  # - revive
-  # - scopelint
-  # - wsl
-
-issues:
-  exclude:
-    - 'declaration of "(err|ctx)" shadows declaration at'
-    - "G402: TLS InsecureSkipVerify may be true"
-    - "`(F|f)ibre` is a misspelling"
-    - "`(C|c)ancell.*` is a misspelling"
-    - "Error return value of `original.UnmarshalJSON` is not checked"
-  exclude-dirs:
-    - examples
-    - tools
+  settings:
+    depguard:
+      rules:
+        prevent_unmaintained_packages:
+          list-mode: lax
+          files:
+            - $all
+            - '!$test'
+          allow:
+            - $gostd
+          deny:
+            - pkg: io/ioutil
+              desc: 'replaced by io and os packages since Go 1.16: https://tip.golang.org/doc/go1.16#ioutil'
+    dupl:
+      threshold: 200
+    funlen:
+      lines: 100
+      statements: 50
+    goconst:
+      min-len: 2
+      min-occurrences: 5
+    gocritic:
+      disabled-checks:
+        - deprecatedComment
+        - dupImport
+        - ifElseChain
+        - octalLiteral
+        - whyNoLint
+        - wrapperFunc
+      enabled-tags:
+        - diagnostic
+        - experimental
+        - opinionated
+        - performance
+        - style
+    gocyclo:
+      min-complexity: 30
+    goheader:
+      values:
+        const:
+          LICENSE: BSD-3-Clause
+      template: 'SPDX-License-Identifier: {{ LICENSE }}'
+    govet:
+      disable:
+        - fieldalignment
+      enable-all: true
+    misspell:
+      locale: US
+    nolintlint:
+      require-explanation: false
+      require-specific: false
+      allow-unused: false
+  exclusions:
+    generated: lax
+    presets:
+      - comments
+      - common-false-positives
+      - legacy
+      - std-error-handling
+    rules:
+      - path: (.+)\.go$
+        text: declaration of "(err|ctx)" shadows declaration at
+      - path: (.+)\.go$
+        text: 'G402: TLS InsecureSkipVerify may be true'
+      - path: (.+)\.go$
+        text: '`(F|f)ibre` is a misspelling'
+      - path: (.+)\.go$
+        text: '`(C|c)ancell.*` is a misspelling'
+      - path: (.+)\.go$
+        text: Error return value of `original.UnmarshalJSON` is not checked
+    paths:
+      - examples
+      - tools
+      - third_party$
+      - builtin$
+      - examples$
+formatters:
+  enable:
+    - gci
+    - goimports
+  settings:
+    goimports:
+      local-prefixes:
+        - github.com/stmcginnis
+  exclusions:
+    generated: lax
+    paths:
+      - examples
+      - tools
+      - third_party$
+      - builtin$
+      - examples$
diff --git a/Makefile b/Makefile
@@ -4,7 +4,7 @@
 
 PKGS := $(shell go list ./... | grep -v example | grep -v tools)
 ROOT_DIR := $(shell git rev-parse --show-toplevel)
-GOLANGCI_VERSION := "v1.59.1"
+GOLANGCI_VERSION := "v2.1.6"
 
 all: lint build test
 

diff --git a/common/entity.go b/common/entity.go
@@ -113,16 +113,7 @@ func (e *Entity) Get(c Client, uri string, payload interface{}) error {
 
 // Patch performs a Patch request against the Redfish service with etag
 func (e *Entity) Patch(uri string, payload interface{}) error {
-	header := make(map[string]string)
-	if e.etag != "" && !e.disableEtagMatch {
-		if e.stripEtagQuotes {
-			e.etag = strings.Trim(e.etag, "\"")
-		}
-
-		header["If-Match"] = e.etag
-	}
-
-	resp, err := e.client.PatchWithHeaders(uri, payload, header)
+	resp, err := e.client.PatchWithHeaders(uri, payload, e.headers())
 	if err == nil {
 		return resp.Body.Close()
 	}
@@ -131,26 +122,22 @@ func (e *Entity) Patch(uri string, payload interface{}) error {
 
 // Post performs a Post request against the Redfish service with etag
 func (e *Entity) Post(uri string, payload interface{}) error {
-	header := make(map[string]string)
-	if e.etag != "" && !e.disableEtagMatch {
-		if e.stripEtagQuotes {
-			e.etag = strings.Trim(e.etag, "\"")
-		}
-
-		header["If-Match"] = e.etag
-	}
-
-	resp, err := e.client.PostWithHeaders(uri, payload, header)
+	resp, err := e.PostWithResponse(uri, payload)
 	if err == nil {
 		return resp.Body.Close()
 	}
+
 	return err
 }
 
 // PostWithResponse performs a Post request against the Redfish service with etag,
 // returning the response from the service.
 // Callers should make sure to call `resp.Body.Close()` when done with the response.
 func (e *Entity) PostWithResponse(uri string, payload interface{}) (*http.Response, error) {
+	return e.client.PostWithHeaders(uri, payload, e.headers())
+}
+
+func (e *Entity) headers() map[string]string {
 	header := make(map[string]string)
 	if e.etag != "" && !e.disableEtagMatch {
 		if e.stripEtagQuotes {
@@ -159,8 +146,7 @@ func (e *Entity) PostWithResponse(uri string, payload interface{}) (*http.Respon
 
 		header["If-Match"] = e.etag
 	}
-
-	return e.client.PostWithHeaders(uri, payload, header)
+	return header
 }
 
 type Filter string
@@ -208,6 +194,8 @@ func getPatchPayloadFromUpdate(originalEntity, updatedEntity reflect.Value) (pay
 		}
 		fieldName := field.Name
 		jsonName := field.Tag.Get("json")
+		// Strip out marshaling directives
+		jsonName = strings.ReplaceAll(jsonName, ",omitempty", "")
 		if jsonName == "-" {
 			continue
 		}

diff --git a/common/entity_test.go b/common/entity_test.go
@@ -13,8 +13,9 @@ type nestedStruct struct {
 	X bool `json:"x"`
 	Y []string
 }
+
 type F struct {
-	Field string
+	Field string `json:",omitempty"`
 }
 
 type testStruct struct {

diff --git a/common/types.go b/common/types.go
@@ -213,10 +213,11 @@ type Condition struct {
 
 // Status describes the status and health of a resource and its children.
 type Status struct {
-	Health       Health      `json:"Health"`
-	HealthRollup Health      `json:"HealthRollup"`
-	State        State       `json:"State"`
-	Conditions   []Condition `json:"Conditions"`
+	Health       Health          `json:"Health"`
+	HealthRollup Health          `json:"HealthRollup"`
+	State        State           `json:"State"`
+	Conditions   []Condition     `json:"Conditions"`
+	OEM          json.RawMessage `json:"Oem"`
 }
 
 // LocationType shall name the type of location in use.

diff --git a/oem/smc/ikvm.go b/oem/smc/ikvm.go
@@ -54,6 +54,7 @@ func (i *IKVM) Update() error {
 
 	readWriteFields := []string{
 		"CurrentInterface",
+		"Current Interface",
 	}
 
 	originalElement := reflect.ValueOf(orig).Elem()

diff --git a/oem/smc/ipaccesscontrol.go b/oem/smc/ipaccesscontrol.go
@@ -71,6 +71,7 @@ func (i *IPAccessControl) Update() error {
 
 	readWriteFields := []string{
 		"Enabled",
+		"ServiceEnabled",
 	}
 
 	originalElement := reflect.ValueOf(orig).Elem()

diff --git a/oem/smc/lldp.go b/oem/smc/lldp.go
@@ -60,6 +60,7 @@ func (i *LLDP) Update() error {
 
 	readWriteFields := []string{
 		"Enabled",
+		"LLDPEnabled",
 	}
 
 	originalElement := reflect.ValueOf(orig).Elem()

diff --git a/oem/smc/memoryhealthcomp.go b/oem/smc/memoryhealthcomp.go
@@ -56,6 +56,7 @@ func (i *MemoryHealthComp) Update() error {
 
 	readWriteFields := []string{
 		"Next",
+		"MemoryHealthCompNext",
    	}
 
 	originalElement := reflect.ValueOf(orig).Elem()

diff --git a/oem/smc/memorypfa.go b/oem/smc/memorypfa.go
@@ -58,6 +58,7 @@ func (i *MemoryPFA) Update() error {
 
 	readWriteFields := []string{
 		"Next",
+		"MemoryPfaNext",
 		"AlertID",
 	}
 

diff --git a/oem/smc/ntp.go b/oem/smc/ntp.go
@@ -56,8 +56,11 @@ func (r *NTP) Update() error {
 
 	readWriteFields := []string{
 		"Enabled",
+		"NTPEnable",
 		"PrimaryServer",
+		"PrimaryNTPServer",
 		"SecondaryServer",
+		"SecondaryNTPServer",
 		"DaylightSavingTime",
 	}
 

diff --git a/oem/smc/radius.go b/oem/smc/radius.go
@@ -56,9 +56,13 @@ func (r *RADIUS) Update() error {
 
 	readWriteFields := []string{
 		"Enabled",
+		"RadiusEnabled",
 		"ServerIP",
+		"RadiusServerIP",
 		"PortNumber",
+		"RadiusPortNumber",
 		"Secret",
+		"RadiusSecret",
 	}
 
 	originalElement := reflect.ValueOf(rad).Elem()

diff --git a/oem/smc/syslockdown.go b/oem/smc/syslockdown.go
@@ -53,6 +53,7 @@ func (i *SysLockdown) Update() error {
 
 	readWriteFields := []string{
 		"Enabled",
+		"SysLockdownEnabled",
 	}
 
 	originalElement := reflect.ValueOf(orig).Elem()
-Original file line number
+Diff line change
@@ Expand Up / @@ -56,6 +56,7 @@ func (i *MemoryHealthComp) Update() error { @@
     	readWriteFields := []string{
     		"Next",
+    		"MemoryHealthCompNext",
     	}
     	originalElement := reflect.ValueOf(orig).Elem()
@@ Expand Down @@