This repository was archived by the owner on Jan 30, 2020. It is now read-only.
agent: make TestUnitStatePublisher wait for each goroutine to finish #1651
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
01fbff2 to
00b4aa1
Compare
TestUnitStatePublisherRunWithDelays() has not exactly initiated each
service sequentially, but let it run in parallel. That's why the unit
test sometimes fails with messages like:
```
--- FAIL: TestUnitStatePublisherRunWithDelays-2 (0.00 seconds)
unit_state_test.go:626: bad published UnitStates:
got []string{"0.service", "2.service", "4.service", "1.service", "3.service"},
want []string{"0.service", "1.service", "2.service", "3.service", "4.service"}
unit_state_test.go:640: bad published UnitStates:
got []string{"0.service", "2.service", "4.service", "1.service", "3.service"},
want []string{"0.service", "1.service", "2.service", "3.service", "4.service"}
unit_state_test.go:658: bad UnitStates:
got []string{"foo.service", "baz.service", "bar.service"},
want []string{"foo.service", "bar.service", "baz.service"}
```
To fix that, for each goroutine, check that the channel toPublish
contains the expected unit name.
Suggested by @jonboulle
Fixes coreos#1248
00b4aa1 to
8a8d690
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TestUnitStatePublisherRunWithDelays()has not exactly initiated each service sequentially, but let it run in parallel. That's why the unit test sometimes fails with messages like:To fix that, for each goroutine, check that the channel
toPublishcontains the expected unit name.Suggested by @jonboulle
Fixes #1248