8000 Track v4.1/dev PRs that were inadvertently closed. · Issue #2554 · coreruleset/coreruleset · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Track v4.1/dev PRs that were inadvertently closed. #2554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
14 tasks done
lifeforms opened this issue May 15, 2022 · 1 comment
Closed
14 tasks done

Track v4.1/dev PRs that were inadvertently closed. #2554

lifeforms opened this issue May 15, 2022 · 1 comment
Assignees
@lifeforms
Labels
👍 Feature Request
Milestone
CRS v4.0.0

Comments

@lifeforms
Copy link
Member
lifeforms commented May 15, 2022 •
edited by fzipi
Loading

Since we decided to delay 4.0 to include the fixes from the bug bounty, I changed the default branch back to v4.0/dev and after merging the little work on v4.1/dev, I deleted the v4.1/dev branch. What I didn't know is that deleting this branch made GitHub auto-close all PRs to v4.1/dev with no way to re-open them.

Unfortunately, there seems no way other than re-submitting the PRs based on v4.0/dev branch. I pinged all the authors asking them to re-submit their PRs based on v4.0/dev.

This issue tracks that all v4.1/dev PRs are re-submitted on v4.0/dev:
@lifeforms lifeforms self-assigned this May 15, 2022
@lifeforms lifeforms added this to the CRS v4.0.0 milestone May 15, 2022
This was referenced May 16, 2022
Closed
Closed
Closed
@fzipi
Copy link
Member
fzipi commented Jul 18, 2022

Closing as all changes were merged already.

@fzipi fzipi closed this as completed Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lifeforms lifeforms

Labels
👍 Feature Request
Projects
None yet
Milestone
CRS v4.0.0
Development

No branches or pull requests
2 participants
@fzipi @lifeforms
0