8000 feat(regexp-assemble): Make 951230 work with regexp-assemble by theseion · Pull Request #2535 · coreruleset/coreruleset · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(regexp-assemble): Make 951230 work with regexp-assemble #2535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

theseion
Copy link
Contributor

Rename the data file for 951230 to 951230-chain1.data so regexp-assemble
can properly be used for that rule.

@theseion theseion requested a review from azurit May 10, 2022 19:39 8000
Rename the data file for 951230 to 951230-chain1.data so regexp-assemble
can properly be used for that rule.
@theseion theseion force-pushed the make-941230-work-with-regexp-assemble branch from 2d42d2b to 548244b Compare May 12, 2022 04:59
@lifeforms lifeforms deleted the branch coreruleset:v4.1/dev May 15, 2022 16:05
@lifeforms lifeforms closed this May 15, 2022
@lifeforms
Copy link
Member

@theseion My apologies, but our switch back to the v4.0/dev branch closed all the v4.1/dev PRs and it turns out it is impossible to reopen or rebase them! Could you send this PR again, but based on the v4.0/dev branch? My apologies! Learning new things about GitHub every day...

@lifeforms
Copy link
Member

Some fixes to the regexp-assemble script were merged by @fzipi and also #2553 came in, so beware of conflicts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0