920470: Allow # character #1856
Conversation
|
Well, there was a blank line at the end of the file so i preserved it.. |
|
Thank you very much. Most welcome. @azurit : would you mind sending me your email address? DM welcome. (And sorry if I am supposed to have it. Can't find it in my files.) |
|
@dune73 i sent you an e-mail to your github email address |
|
Am i supposed to do something with these failed tests? Why is it suddenly failing if it wasn't before? |
|
hi @azurit,
if I'm right, the As the operator in rule has a negation ( |
|
I wasn't writing that part of the rule. Sorry, i don't understand what am i supposed to do here. |
yes, the rule as is, you don't need to touch it :). What's your idea in the test case what you added? If you change the This means the given CT header doesn't match with the regex, so the rule is triggered. |
|
The misunderstanding probably was, this test is testing a new rule change, made by @azurit in #1839. The rule should not fire on this input. I could not merge or edit PR #1839, so I have applied the rule change (written by @azurit) to this PR #1856. So now this PR contains the improved rule and the test for it. All tests are green, so we can merge both the change and the test! Thanks again @azurit ! |
Adding test for pull request #1839.