Add support for sec-ch-ua and sec-ch-ua-mobile within Validate Bytes … #1970
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rule Chrome has decided to add new user agent headers, here we add support for ignoring them as we do similarly with the old user-agent header https://www.chromestatus.com/feature/5995832180473856
|
You are only doing this on 920274. What do you think about covering 920272 as well? Probably also with the existing headers or are they sticking on lower range, visible ascii on those headers and thus don't trigger 920272 ever? |
|
920272 has exception for Referer and UA. So it is only natural to not add exceptions for these new headers. Thank you for your contribution, @csanders-git. Merging now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rule
Chrome has decided to add new user agent headers, here we add support for ignoring them as we do similarly with the old user-agent header
https://www.chromestatus.com/feature/5995832180473856